Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating to ESM #3

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

Migrating to ESM #3

wants to merge 1 commit into from

Conversation

CMCDragonkai
Copy link
Member

@CMCDragonkai CMCDragonkai commented May 15, 2024 •
edited
Loading

Description

This migrates to ESM.

Issues Fixed

Tasks

  • 1. Migrating to ESM
  • 2. Fix fast-check

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@CMCDragonkai CMCDragonkai self-assigned this May 15, 2024
@CMCDragonkai CMCDragonkai mentioned this pull request May 15, 2024
Closed
@CMCDragonkai
Copy link
Member Author

Seems like something is wrong with @fast-check/jest. Importing it results in some problem here. Something to do with ESM or otherwise: dubzzz/fast-check#4986

@CMCDragonkai
Copy link
Member Author

ESM code can load CJS code.

However they cannot destructure on import anymore. So for example, this is what is necessary for the Counter:

import resourceCounter from 'resource-counter';

const { default: Counter } = resourceCounter;

@CMCDragonkai CMCDragonkai mentioned this pull request Aug 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CMCDragonkai CMCDragonkai

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CMCDragonkai